Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All metrics are invalid with NaN or 0 #222

Closed
AlexV525 opened this issue Jan 6, 2023 · 8 comments · Fixed by #224
Closed

All metrics are invalid with NaN or 0 #222

AlexV525 opened this issue Jan 6, 2023 · 8 comments · Fixed by #224

Comments

@AlexV525
Copy link
Contributor

AlexV525 commented Jan 6, 2023

For example https://github.com/jasonlong

image

@Zxilly
Copy link

Zxilly commented Jan 6, 2023

Same problem

I debug the content script, seems dataset no longer contains count property.

image

image

And a possible fix can be parse contribution string with regex?

@Leslie-Wong-H
Copy link

The same experience.

@gurezo
Copy link

gurezo commented Jan 7, 2023

me too.
I have confirmed the same phenomenon in Firefox and Chrome,
Firefox v108.0.2 (64 bit)
Chrome v108.0.5359.124(Official Build) (arm64)

@Anass001
Copy link

Anass001 commented Jan 8, 2023

Same issue, thought it's a problem on my side.
Chrome v108.0.5359.125 (Official Build) (64-bit)

@thevinitgupta
Copy link

I am having the same issue

@AlexV525
Copy link
Contributor Author

AlexV525 commented Jan 8, 2023

And a possible fix can be parse contribution string with regex?

I managed to solve the issue with your idea and a regexp. See #224 for more of the fix.

@jasonlong
Copy link
Owner

Sorry for the delay everyone - I was traveling over the weekend. I checked out your fix @AlexV525 and it seems to work great. Thank you!

I'll merge this now and publish updated extensions after.

@jasonlong
Copy link
Owner

Still waiting for the Chrome extension to be approved. It's usually very fast, but it's been pending all day. Hopefully soon 🤞🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants