Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastBoot is not defined – Issues with lazy-loading engines and ember-cli-moment-shim #145

Closed
briangonzalez opened this issue Aug 30, 2017 · 8 comments
Assignees

Comments

@briangonzalez
Copy link

briangonzalez commented Aug 30, 2017

We're attempting to use ember-cli-moment-shim in our non-fastbooted ember app. We're encountering an error when we navigate to our lazy-loaded engine (see below).

I suspect this line is causing the issue, as FastBoot is not defined.

Any ideas?

screen shot 2017-08-30 at 8 37 45 am

@jasonmit
Copy link
Owner

jasonmit commented Aug 30, 2017

@briangonzalez First time this is reported and it's used heavily through ember-moment. I suspect Ember engines is doing something that I wasn't anticipating. Can you replicate it with a dummy app?

If not, I have some ideas on how to remove FastBoot.require. Will try that later on tonight if I don't hear back.

@majew7
Copy link

majew7 commented Aug 30, 2017

@jasonmit This issue was reproducible when building in 'production' environment mode.

ember build --environment "production"

Context:

  • Ember Engine uses ember-cli-moment-shim
  • Build in 'production' env
  • Not using FastBoot

@jasonmit
Copy link
Owner

Thanks for the feedback @majew7, the issue occurs with and without lazy engines?

@jasonmit
Copy link
Owner

jasonmit commented Sep 3, 2017

Before I version, can either of you verify this fixes the issue:
591ae7a

@majew7
Copy link

majew7 commented Sep 6, 2017

Yes, @jasonmit, I will verify in the next 24 hours.

@majew7
Copy link

majew7 commented Sep 6, 2017

Hi @jasonmit,
While my local development test looked good with
"ember-cli-moment-shim": "jasonmit/ember-cli-moment-shim.git#591ae7a",
I wanted to also verify in our QA environment. I should know soon.

@jasonmit
Copy link
Owner

jasonmit commented Sep 6, 2017

3.5.0 resolves this, thanks everyone

@jasonmit jasonmit closed this as completed Sep 6, 2017
@jasonmit jasonmit reopened this Sep 6, 2017
@jasonmit jasonmit closed this as completed Sep 6, 2017
@majew7
Copy link

majew7 commented Sep 7, 2017

Thanks @jasonmit! We are consuming the new 3.5.0 version. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants