Support GNU/kFreeBSD #113
Support GNU/kFreeBSD #113
Conversation
| @@ -172,6 +172,9 @@ | |||
| <condition property="os.prefix" value="freebsd-${os.arch}"> | |||
| <os name="FreeBSD"/> | |||
| </condition> | |||
| <condition property="os.prefix" value="linux-${jre.arch}"> | |||
| <os name="GNU/kFreeBSD"/> | |||
| </condition> | |||
There was a problem hiding this comment.
Is this target binary-compatible with the other targets that generate linux-XXX binaries? It's not strictly an issue with this patch, since this patch enables builds but does not bundle the resulting binaries, but it could lead to some confusion.
There was a problem hiding this comment.
This one is copied from how Debian has been building for GNU/kFreeBSD for the last year or so. I'm not really sure what the implications are of using a different string here - can we just change it to kfreebsd (both here and in native/Makefile)?
There was a problem hiding this comment.
Actually I had more of a look. I think I'd need to add the right compilation flags in native/Makefile too, but should be able to mostly copy the linux ones. I'll have a go with that tomorrow.
|
I've had more of a play once I got my kfreebsd VM working. I think you're right that it's best to have a separate target name, so I've added kfreebsd in (hopefully all of) the relevent places. My latest changes are now in this branch. |
|
@rockclimb Please update this PR. You don't have to embed the resulting shared library into jna.jar (if you do, make sure you provide lib/native/xxx/libjnidispatch.so). Also please include whatever additional targets you need to support debian builds. |
|
OK, I've updated the branch, and left it so it won't embed the shared library (unless you're building on kfreebsd, when it does anyway because the .so is in the build tree). I also added a target "nonativejar" which builds the jar file without including any native libraries (these get deployed separately in Debian/Ubuntu). Feel free to suggest a better name for this task! Thanks, |
|
yeah, I've been thinking there needs to be a jna-min.jar target of some sort... On Oct 5, 2012, at 5:35 PM, rockclimb wrote:
|
Motivation: We should use the same docker / docker-compose file for the CI as we do when we build locally. This helps to keep things consistent and easy to reproduce Modifications: - Add new workflow that uses docker / docker-compose - Adjust dockerfile to pre-download all dependencies - Adjust dockerfile to pre-build quiche - Add new docker-compose task that can be used to run the build against the pre-build quiche and so save time Result: Better CI setup
This pull request is for changes to enable building of JNA on GNU/kFreeBSD:
It is used in the Debian build of JNA, and I would appreciate it if you would consider merging it into the source.
Andy