Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CM_Get_DevNode_Registry_Property to Cfgmgr32 and Cfgmgr32Util #1340

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Added CM_Get_DevNode_Registry_Property to Cfgmgr32 and Cfgmgr32Util #1340

merged 1 commit into from
Apr 21, 2021

Conversation

dbwiddis
Copy link
Contributor

No description provided.

@dbwiddis dbwiddis force-pushed the cfgmgr branch 5 times, most recently from 86b5e2f to 5ac24f4 Compare April 18, 2021 20:38
@dbwiddis
Copy link
Contributor Author

dbwiddis commented Apr 20, 2021 •
edited
Loading

Checkstyle doesn't like Java Coding Convention standard for switch/case. I can't easily switch it in my IDE, either. Maybe i'll just make it an if/then...

matthiasblaesing
matthiasblaesing reviewed Apr 20, 2021
View reviewed changes
Copy link
Member

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly sane to me, I left two inline comments.

contrib/platform/src/com/sun/jna/platform/win32/Advapi32Util.java Outdated Show resolved Hide resolved
contrib/platform/src/com/sun/jna/platform/win32/Cfgmgr32Util.java Outdated Show resolved Hide resolved
matthiasblaesing
matthiasblaesing approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@dbwiddis
Copy link
Contributor Author

Thanks as always for your patience and educational code review.

@dbwiddis dbwiddis merged commit 7a33efb into java-native-access:master Apr 21, 2021
@dbwiddis dbwiddis deleted the cfgmgr branch January 9, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwiddis @matthiasblaesing