Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or extend structures needed to read HKEY_PERFORMANCE_DATA #980

Closed
wants to merge 2 commits into from

Conversation

dbwiddis
Copy link
Contributor

No description provided.

@dbwiddis dbwiddis force-pushed the master branch 5 times, most recently from d69a8ce to 8a4c5c3 Compare June 29, 2018 21:11
public int CounterNameTitle; // always 32 bit
public int CounterHelpTitleIndex;
public int CounterHelpTitle; // always 32 bit
public NativeLong DefaultScale;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the header this is:
LONG DefaultScale;
the other encounters of LONG are mapped to int (according to windows definition LONG is a 32 bit integer)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've bookmarked this page so I'll stop guessing...


// PERF_DATA_BLOCK test
// Test the signature, a char[] containing [P, E, R, F]
PERF_DATA_BLOCK perfData = new PERF_DATA_BLOCK(pPerfData.share(0));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the share(0) and not directly pass in the pPerfData? Is this for consistency with the following share calls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intent was to highlight the fact that the PERF_DATA_BLOCK is only the first portion of the allocated pPerfData memory. So there was somewhat of a consistent approach with that vs. the other calls. I agree that it's not necessary, however, and I'll remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants