Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Declaration parsing allocates too much #81

Closed
glassfishrobot opened this issue Oct 3, 2015 · 7 comments
Closed

Declaration parsing allocates too much #81

glassfishrobot opened this issue Oct 3, 2015 · 7 comments
Assignees
@glassfishrobot
Labels
Component: code ERR: Assignee Priority: Major Type: Bug
Milestone
1.3.26

Comments

@glassfishrobot
Copy link
Contributor

We're seeing a lot of allocation pressure due to declaration parsing. XMLDeclarationParser always allocates a character array of size 65535. This is quite excessive. Also it's not needed since all the content is already in a StringBuffer.
@glassfishrobot
Copy link
Contributor Author

Reported by braghest

@glassfishrobot
Copy link
Contributor Author

Was assigned to gagordon

@glassfishrobot
Copy link
Contributor Author

braghest said:
Here's the pull request:
https://github.com/gf-metro/saaj/pull/2

@glassfishrobot
Copy link
Contributor Author

braghest said:
Here are screenshots where you can see allocations outside TLABs caused by XMLDeclarationParser

@glassfishrobot
Copy link
Contributor Author

braghest said:
pull request has been merged into 1.3.26

@glassfishrobot
Copy link
Contributor Author

Marked as fixed on Tuesday, February 14th 2017, 10:54:50 am

@glassfishrobot
Copy link
Contributor Author

This issue was imported from java.net JIRA SAAJ-81

@glassfishrobot glassfishrobot added this to the 1.3.26 milestone Apr 24, 2017
@glassfishrobot glassfishrobot self-assigned this Apr 24, 2017
@glassfishrobot glassfishrobot mentioned this issue Apr 24, 2017
Open
@Tomas-Kraus Tomas-Kraus mentioned this issue Sep 24, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glassfishrobot glassfishrobot

Labels
Component: code ERR: Assignee Priority: Major Type: Bug
Projects
None yet
Milestone
1.3.26
Development

No branches or pull requests
1 participant
@glassfishrobot