Skip to content

Commit 79b0576

Browse files
committed
Remove RestGetAllAliasesAction
We currently have a specific REST action to retrieve all aliaes, which uses internally the get index API. This doesn't seem to be required anymore though as the existing RestGetAliaesAction could as well take the requests with no indices and aliases specified. This commit removes the RestGetAllAliasesAction in favour of using RestGetAliasesAction also for requests that don't specify indices nor aliases. Similar to elastic#31129.
1 parent d5e8a5c commit 79b0576

File tree

3 files changed

+2
-106
lines changed

3 files changed

+2
-106
lines changed

server/src/main/java/org/elasticsearch/action/ActionModule.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,6 @@
254254
import org.elasticsearch.rest.action.admin.indices.RestFlushAction;
255255
import org.elasticsearch.rest.action.admin.indices.RestForceMergeAction;
256256
import org.elasticsearch.rest.action.admin.indices.RestGetAliasesAction;
257-
import org.elasticsearch.rest.action.admin.indices.RestGetAllAliasesAction;
258257
import org.elasticsearch.rest.action.admin.indices.RestGetFieldMappingAction;
259258
import org.elasticsearch.rest.action.admin.indices.RestGetIndexTemplateAction;
260259
import org.elasticsearch.rest.action.admin.indices.RestGetIndicesAction;
@@ -553,8 +552,6 @@ public void initRestHandlers(Supplier<DiscoveryNodes> nodesInCluster) {
553552
registerHandler.accept(new RestRestoreSnapshotAction(settings, restController));
554553
registerHandler.accept(new RestDeleteSnapshotAction(settings, restController));
555554
registerHandler.accept(new RestSnapshotsStatusAction(settings, restController));
556-
557-
registerHandler.accept(new RestGetAllAliasesAction(settings, restController));
558555
registerHandler.accept(new RestGetIndicesAction(settings, restController, indexScopedSettings, settingsFilter));
559556
registerHandler.accept(new RestIndicesStatsAction(settings, restController));
560557
registerHandler.accept(new RestIndicesSegmentsAction(settings, restController));

server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestGetAliasesAction.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ public class RestGetAliasesAction extends BaseRestHandler {
6060

6161
public RestGetAliasesAction(final Settings settings, final RestController controller) {
6262
super(settings);
63+
controller.registerHandler(GET, "/_alias", this);
64+
controller.registerHandler(GET, "/_aliases", this);
6365
controller.registerHandler(GET, "/_alias/{name}", this);
6466
controller.registerHandler(HEAD, "/_alias/{name}", this);
6567
controller.registerHandler(GET, "/{index}/_alias", this);

server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestGetAllAliasesAction.java

Lines changed: 0 additions & 103 deletions
This file was deleted.

0 commit comments

Comments
 (0)