Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NumPy set routines #2078

Closed
8 tasks done
shoyer opened this issue Jan 26, 2020 · 1 comment
Closed
8 tasks done

Implement NumPy set routines #2078

shoyer opened this issue Jan 26, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@shoyer
Copy link
Collaborator

shoyer commented Jan 26, 2020 •
edited by jakevdp
Loading

Extracted from #70:

  • np.unique
  • np.ediff1d
  • np.in1d
  • np.intersect1d
  • np.isin
  • np.setdiff1d
  • np.setxor1d
  • np.union1d

Implementation wise, we could use either sorting (like NumPy) or hash-tables (of some sort) for most of these fucntions.

Some of these could be challenging to implement (would not work under jit), because the output has a dynamic shape. in1d and isin don't have dynamic shapes, but that they probably require searchsorted from #2080 first (at least if using sorting).
@shoyer shoyer changed the title Implement NumPy's set routines Implement NumPy set routines Jan 26, 2020
@alexbw alexbw mentioned this issue Jan 26, 2020
Closed
9 tasks
@shoyer shoyer added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 26, 2020
@joschkabraun joschkabraun mentioned this issue Apr 15, 2020
Merged
@oliverastrand oliverastrand mentioned this issue Apr 20, 2020
Merged
This was referenced May 3, 2020
Closed
Closed
@jakevdp jakevdp mentioned this issue May 13, 2020
Merged
@aldragan0 aldragan0 mentioned this issue Jul 12, 2020
Merged
@aldragan0 aldragan0 mentioned this issue Oct 17, 2020
Merged
This was referenced Feb 6, 2021
Merged
Merged
@jakevdp
Copy link
Collaborator

jakevdp commented Feb 24, 2021

#5665 finishes this work!

@jakevdp jakevdp closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakevdp @shoyer