Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-upload-client doesn't have compatibility with apollo-client >= v3.5.0 #273

Closed
pipopotamasu opened this issue Nov 11, 2021 · 3 comments

Comments

@pipopotamasu
Copy link

pipopotamasu commented Nov 11, 2021

HttpLink has accepts print option since apollo-client v3.5.0.
https://github.com/apollographql/apollo-client/pull/8699/files

In this change, arguments of selectHttpOptionsAndBody function also changed which is used in createHttpLink.
https://github.com/apollographql/apollo-client/pull/8699/files#diff-302faec6602520ccb4f8947dc7614daf1c40de0c264de8dbcd4104502ac3f5a0R116

We need to add print option to selectHttpOptionsAndBody through createHttpLink to get along with apollo-client >= v3.5.0.

@jaydenseric
Copy link
Owner

jaydenseric commented Nov 23, 2021

I originally intended to work on this issue last week, but the other project I wanted to finish first hit a few snags and I couldn't get it done before going on a pre-planned hiking trip in the bush over the weekend. Also, my new MacBook Pro arrived and I've been fiddling around migrating from the old machine.

Apollo have acknowledged this issue is a due to a breaking change that they incorrectly published in an Apollo Client semver non-major release, and they have a PR that will fix the problem soon: apollographql/apollo-client#9103 .

We will still add support for the new print option here via #274, but it will be as a new feature instead of an urgent bug fix. That PR needs a bit more work (documentation of the new option, changelog entry, etc.) that I intend to do once we can base it on the coming Apollo Client patch release. We need to think carefully about if supporting the new feature will be a server major change for this package. I might introduce some other unrelated breaking changes into the next release anyway (updated Node.js version support, deep import path simplifications, etc.).

@jaydenseric
Copy link
Owner

Closing because this issue should be fixed in Apollo Client v3.5.5:

https://github.com/apollographql/apollo-client/blob/main/CHANGELOG.md#apollo-client-355-2021-11-23

We can track adding support for the new print option in another issue/PR.

@tm1000
Copy link

tm1000 commented Nov 29, 2021

Thanks @jaydenseric !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants