Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle pinyin option #545

Open
ghost opened this issue Feb 13, 2021 · 6 comments
Open

Toggle pinyin option #545

ghost opened this issue Feb 13, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Feb 13, 2021

Would be cool to implement a "Show Pinyin" button. I personally find it distracting to have the characters under the pinyin as I don't learn with pinyin but by sound. If it could be a toggle button one could still see the pinyin but it wouldn't be the first thing one sees.

@ghost ghost added the enhancement New feature or request label Feb 13, 2021
@Kvaibhav01
Copy link
Contributor

@yaoberh can you elaborate on the issue?

@ghost
Copy link
Author

ghost commented Feb 14, 2021

It's not an issue. Pretty simple actually. Put a toggle button son pinyin can be shown if necessary but it's not there when you see the word. It's pretty distracting to see the pronunciation for those of us who don't use pinyin to learn chinese.

@jayehernandez
Copy link
Owner

Hey @yaoberh! I just searched and pinyin seems to be the official romanization for Chinese. We can definitely add a "Hide Romanization" checkbox in the options menu so that it's a catch all for all the different languages. Would you like to work on this, or can I open it up to whoever wants to do so?

@ghost
Copy link
Author

ghost commented Feb 16, 2021

I know it's the official romanization but nonetheless it's a confusing and unintuitive method of learning chinese. Many people prefer to learn by sound or Bopomofo (Taiwan) as I do myself. It's much better to learn this way as you don't learn by reading romanizations of characters but the characters directly. You also acquire the sounds by listening and not by seeing a letter with a tone which I find stupid. I'm not a developer so yeah, open it up to whoever can! Thanks :)

@bhavinip
Copy link

Hello! Would it be possible to be assigned to this issue! This extension is really cool, and I would love to contribute. I have taken several years of Chinese and am a Computer Science major! Thank you!

@jayehernandez
Copy link
Owner

Hey @bhavinip sorry for the late revert! I just put this repo in vacation mode as I currently don't have the capacity to maintain it for now. I'll let you know when I revert it back. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants