Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in image URL will break the caching #37

Open
morelazers opened this issue Jan 9, 2017 · 3 comments
Open

Special characters in image URL will break the caching #37

morelazers opened this issue Jan 9, 2017 · 3 comments

Comments

@morelazers
Copy link

I fixed this with a simple .replace for my cases, but it definitely needs a more stable solution.

Thanks so much for the module, super useful 👍

@jayesbe
Copy link
Owner

jayesbe commented Jan 30, 2017

Hmm.. can you describe which characters?

@morelazers
Copy link
Author

morelazers commented Jan 30, 2017

The period and percent characters, . & % needed to be replaced in my image path before caching would work. I used:

let safeCacheKey = cacheKey.replace(/\//g, '.').replace(/%/, '.');

@tjkang
Copy link

tjkang commented Feb 15, 2017

I am using firebase storage but got error as well because of url format

https://firebasestorage.googleapis.com/v0/b/abc.appspot.com/o/images%2Ftemp?alt=media&token=9f605564-9daa-46df-96c9-ea3ddf432b79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants