fix

Author: seratch

src/agents/memory/openai_session.py

@@ -1,3 +1,5 @@
+from typing import Optional
+
 from openai import AsyncOpenAI
 
 from agents.models._openai_shared import get_default_openai_client
@@ -6,22 +8,23 @@
 from .session import SessionABC
 
 
-async def start_openai_session(openai_client: AsyncOpenAI | None = None) -> str:
+async def start_openai_session(openai_client: Optional[AsyncOpenAI] = None) -> str:
     _openai_client = openai_client
     if openai_client is None:
         _openai_client = get_default_openai_client() or AsyncOpenAI()
 
-    response = await _openai_client.conversations.create(items=[])
+    response = await _openai_client.conversations.create(items=[])  # type: ignore [union-attr]
     return response.id
 
 
 class OpenAISession(SessionABC):
     def __init__(
         self,
         session_id: str | None = None,
-        openai_client: AsyncOpenAI | None = None,
+        openai_client: Optional[AsyncOpenAI] = None,
     ):
-        self.session_id = session_id
+        # this implementation allows to set this value later
+        self.session_id = session_id  # type: ignore
         self.openai_client = openai_client
         if self.openai_client is None:
             self.openai_client = get_default_openai_client() or AsyncOpenAI()
@@ -35,27 +38,29 @@ async def get_items(self, limit: int | None = None) -> list[TResponseInputItem]:
 
         all_items = []
         if limit is None:
-            async for item in self.openai_client.conversations.items.list(
+            async for item in self.openai_client.conversations.items.list(  # type: ignore [union-attr]
                 conversation_id=self.session_id,
                 order="asc",
             ):
+                # calling model_dump() to make this serializable
                 all_items.append(item.model_dump())
         else:
-            async for item in self.openai_client.conversations.items.list(
+            async for item in self.openai_client.conversations.items.list(  # type: ignore [union-attr]
                 conversation_id=self.session_id,
                 limit=limit,
                 order="desc",
             ):
+                # calling model_dump() to make this serializable
                 all_items.append(item.model_dump())
                 if limit is not None and len(all_items) >= limit:
                     break
             all_items.reverse()
 
-        return all_items
+        return all_items  # type: ignore
 
     async def add_items(self, items: list[TResponseInputItem]) -> None:
         await self._ensure_session_id()
-        await self.openai_client.conversations.items.create(
+        await self.openai_client.conversations.items.create(  # type: ignore [union-attr]
             conversation_id=self.session_id,
             items=items,
         )
@@ -65,15 +70,15 @@ async def pop_item(self) -> TResponseInputItem | None:
         items = await self.get_items(limit=1)
         if not items:
             return None
-        await self.openai_client.conversations.items.delete(
+        await self.openai_client.conversations.items.delete(  # type: ignore [union-attr]
             conversation_id=self.session_id,
-            item_id=items[0].id,
+            item_id=str(items[0]["id"]),  # type: ignore
         )
         return items[0]
 
     async def clear_session(self) -> None:
         await self._ensure_session_id()
-        await self.openai_client.conversations.delete(
+        await self.openai_client.conversations.delete(  # type: ignore [union-attr]
             conversation_id=self.session_id,
         )
-        self.session_id = None
+        self.session_id = None  # type: ignore