Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceTypeFilter should check self.value() #676

Open
hmarty-ea opened this issue Oct 17, 2024 · 3 comments
Open

ResourceTypeFilter should check self.value() #676

hmarty-ea opened this issue Oct 17, 2024 · 3 comments
Assignees

Comments

@hmarty-ea
Copy link

In ResourceTypeFilter, the line return queryset.filter(content_type_id=self.value()) can generate an exception if the value is not an int. This can happen if the URL is manually changed, for instance from ...?resource_type=21 to ...?resource_type=21X

@hramezani
Copy link
Member

hramezani commented Oct 17, 2024

Thanks for reporting. Could you work on a fix?

@9zimin9
Copy link

9zimin9 commented Dec 2, 2024

Hi, I'm just starting with open source.
would it be okay if I take on this issue as the assignee?

@hramezani
Copy link
Member

Hi @9zimin9, Yes, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants