Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set recurrence rule for Nth of every month #160

Closed
SteveHere opened this issue Jan 29, 2020 · 6 comments
Closed

Unable to set recurrence rule for Nth of every month #160

SteveHere opened this issue Jan 29, 2020 · 6 comments

Comments

@SteveHere
Copy link

Proof (Unable to set a new rule for the Nth of every month):
image

However, I can set the 'On the first X' with no problems:
image

JS error message:
image

Running breakpoints show that some attribute from recurrence called 'langauge_code' was supposed to be called over, but it doesn't exist:
image

@SteveHere
Copy link
Author

SteveHere commented Jan 29, 2020

Found temporary fix by simply running recurrence.language_code = "en", but this leaves out the french translation.

@SteveHere
Copy link
Author

Okay, so... recurrence.language_code wasn't set in recurrence.js, that part's certain... now comes the problem of trying to set recurrence.language_code.

I'm entering from a point of direct face-to-wall here, but the only way for language_code to be flexible would be to have it as a SETTINGS variable for users to hook a view to. And then call the view user-side, which will resolve what the language_code would be.

@derpadoo
Copy link

Seeing something similar.

Python 3.6
Django==2.2.10
django-recurrence==1.10.1

Trying to set a recurrence for the 1st and 15th of the month through the Django Admin.

image

The POST request inspected using DevTools (data isn't being passed correctly):

image

The result

image

I can modify it using a Django Rest Framework API endpoint by setting the payload as:

'recurrences': 'RRULE:FREQ=MONTHLY;BYMONTHDAY=1,15\nRDATE:20200315T050000Z'

which makes it look like it is a javascript issue, but I'm not able to debug that.

@derpadoo
Copy link

@derpadoo
Copy link

Traced the bug to where @SteveHere originally identified it in: https://github.com/django-recurrence/django-recurrence/blob/master/recurrence/static/recurrence/js/recurrence.js#L448

French language logic was added by @ollb in PR #32

Release was 1.2.0

image

@lino
Copy link
Contributor

lino commented Jul 11, 2022

This was fixed in 7190d6c

@lino lino closed this as completed Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants