Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation example for custom flag #420

Closed
TAnas0 opened this issue Jan 6, 2022 · 1 comment
Closed

Documentation example for custom flag #420

TAnas0 opened this issue Jan 6, 2022 · 1 comment

Comments

@TAnas0
Copy link

TAnas0 commented Jan 6, 2022

The documentation for the custom flag shows an example and it might lead to errors and confusion: https://waffle.readthedocs.io/en/stable/types/flag.html#custom-flag-models

The imported get_cache method is not used and the cache variable referenced is undefined.

Is there a missing cache = get_cache() somewhere? Should be placed outside of the class or defined as a class attribute?
@dancergraham
Copy link
Contributor

This looks OK to me with the latest documentation version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TAnas0 @dancergraham