-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release new version to PyPI #236
Comments
@davesque I’m just part of the triage team, but we could try to have a GitHub action that automatically pushes this repo’s releases to PyPi. |
Yeah, I'll do this in the next day or two when I find a moment. I'd also like to start using towncrier to make release note generation easier. |
@davesque are you comfortable using GH workflows? There was a bit of discussion about security concerns regarding using Python fam's workflow regarding twine and such in Django Rate-Limit. It would make things faster, and GH secrets are hidden from others. |
You mean to auto publish new versions? |
Yesorta. You would still need to create a release tag wit git/github. Using the release tags, we can publish new versions, do a check to make sure the latest commit passes tests, make sure the version was actually bumped, and upload it with twine tokens in GH secrets. We can use custom commands if need be for docs as well. Separate workflows can be triggered by separate tags, if need be. |
Given the current |
Hello everybody, it would be cool if we can bump up a new release. |
@Andrew-Chen-Wang Maybe we can just use semantic versioning using this package. And even automated the whole thing with semantic releases with this package. |
@davesque Would it be possible to manually push up a new release to PyPI? Thanks. |
@davesque I can take care of the publishing automation part if you want using GH Actions. It has been almost 2 months and this issue needs to be addressed as the current release fails to install when using Poetry. It has been fixed but has not been published yet. |
I feel like it's a bit unfair to suggest that 2 months is too long to wait for a release or that I "need" to do anything at all for free. And can we agree that the last two months have been a little unusual? |
You're right @davesque. Please take your time. I'll work with a fork + private package till then. |
@codegabru Thanks for your understanding. And I'm sorry for being a bit snippy. |
@davesque I think it's just really annoying for some devs to constantly see this. I mostly develop test-driven (I don't think I've ran
Regarding towncrier, we can also integrate that into GitHub actions as well: twisted/towncrier#175 (comment) @codegabru We can implement those package per Dave's thoughts. In the Django ratelimit package, which btw includes many integral Django community members, the head maintainer doesn't like the automated release process, and they don't publish very frequently either. They like to do things manually. You'll just have to respect people's decisions and opinions. Also packages take a lot of maintenance hence a triage team which seems to be mostly me atm... Just understand that open source projects are just open source, which is why people take over repos, make forks or go over to Jazzband, or simply abandon a repo altogether when it's direly needed (I'm a victim of this: In retrospect after triaging many issues in this repo, I've come to realize many devs like a lot of flexibility when it comes to security (eh hem like Auth0), which is supposed to be stringent (eh hem like OAuth + JWT). An automated process of anything makes life much easier, in any space, not just programming, but I don't want a future maintainer to start publishing like crazy when it's clearly unnecessary and some concepts are not completely proven (eh hem like issue 71). |
@davesque Friendly ping to see if a new release could be issued. |
@davesque Another friendly ping to see if we can get a new version released on PyPI. Thank you! |
This would be great to get onto pypi. Thank you! |
Released! Thanks for being patient! |
Could a new release be pushed to PyPI that includes #186?
For users using Django 3.0,
django-rest-framework-simplejwt
currently throws a warning. If running unit tests with-Werror
, this causes builds to failed unless the warning is suppressed.The text was updated successfully, but these errors were encountered: