Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sha256 hashes from warehouse #543

Closed
graingert opened this issue Jul 24, 2017 · 9 comments · Fixed by #1109
Closed

use sha256 hashes from warehouse #543

graingert opened this issue Jul 24, 2017 · 9 comments · Fixed by #1109
Labels
enhancement Improvements to functionality feature Request for a new feature PR wanted Feature is discussed or bug is confirmed, PR needed

Comments

@graingert
Copy link
Member

graingert commented Jul 24, 2017

Generating hashes is too slow, use the hashes from warehouse.

eg: click the SHA256 buttons: https://pypi.org/project/gitchart/#files

@vphilippon
Copy link
Member

@graingert Is this still needed/relevent with #557 merged?

@graingert
Copy link
Member Author

Yes. Means you don't have to download the package to get the hash

@Mogost
Copy link
Member

Mogost commented Feb 5, 2019

That is really good idea to get hashes from warehouse.
It speeds up a lot
It would be nice to have as an option.

@atugushev atugushev added feature Request for a new feature needs discussion Need some more discussion labels Sep 19, 2019
@graingert
Copy link
Member Author

@atugushev does this still need the needs discussion Need some more discussion

@atugushev
Copy link
Member

@graingert I think so. Is there an API where we could get hashes from warehouse?

@graingert
Copy link
Member Author

@atugushev
Copy link
Member

@graingert cool, thanks!

@atugushev atugushev added PR wanted Feature is discussed or bug is confirmed, PR needed and removed needs discussion Need some more discussion labels Feb 10, 2020
@graingert
Copy link
Member Author

@atugushev it also includes package dependency information which would save downloading any packages at all

@atugushev
Copy link
Member

I made a PR #1109, please test/review. Thanks!

@atugushev atugushev added the enhancement Improvements to functionality label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality feature Request for a new feature PR wanted Feature is discussed or bug is confirmed, PR needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants