Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-compile sets wrong dependencies for social-auth-core under python3 #575

Closed
mhozza opened this issue Oct 8, 2017 · 8 comments
Closed

Comments

@mhozza
Copy link

mhozza commented Oct 8, 2017

Describe the issue briefly here.
social-auth-core has different set of dependencies for python 2 and 3.
with python 2 it requires python-openid, whereas with python 3 it requires python3-openid.
When I install social-auth-core via pip, it installs the correct dependency.
When I generate a requirements.txt file, it adds a dependency for:
python-openid==2.2.5 # via social-auth-core, which is incopatible with python3.

Environment Versions
  1. Linux
  2. Python version: 3.6.2
  3. pip version: 9.0.1
  4. pip-tools version: 1.10.1
Steps to replicate
  1. create a requirements.in with social-auth-core
  2. run pip-compile requirements.in under python3
Expected result

python-openid dependency is:
python3-openid==3.0.10

Actual result

python-openid dependency is:
python-openid==2.2.5

@mhozza
Copy link
Author

mhozza commented Oct 8, 2017

Hmm, this seems to be caching problem - seems like it reuses a cache generated from python2.
adding -r fixes the problem, but it would be nice to have separate cache for each python version or virtal env.

@mhozza mhozza closed this as completed Oct 8, 2017
@mhozza
Copy link
Author

mhozza commented Oct 8, 2017

Hmm, sorry, it does not fix it (it changed behaviour when I installed social-auth-core via pip - after that it put the right dependency).

@mhozza mhozza reopened this Oct 8, 2017
@suutari-ai
Copy link
Contributor

This sounds like the same issue as fixed in PR #571. Can you try if it works with master?

@vphilippon
Copy link
Member

vphilippon commented Oct 10, 2017

I fixed the exact same issue (with the same package) in pipenv by updating its patched-and-vendored version of pip-tools to use the latest fix in pip-tools master branch. I'm pretty sure it should be fixed.

When trying with the master branch, be sure to clear you cache too.

@vphilippon
Copy link
Member

Closing, tell us if the issue still occurs on master.

@vphilippon
Copy link
Member

(Nevermind, reopening to maybe avoid duplicated issues, as I have no idea of when an official release will be made.)

@vphilippon vphilippon reopened this Oct 23, 2017
@vphilippon
Copy link
Member

This is now fixed in 1.10.2
Make sure to clear you dependency cache: pip-compile --rebuild

@pdehaye
Copy link

pdehaye commented Jan 18, 2018

that seems to have done it! weird bug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants