Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating requirements with extra does not update related package versions #768

Closed
Behoston opened this issue Mar 21, 2019 · 5 comments
Closed
Labels
needs reproduce Need to reproduce an issue

Comments

@Behoston
Copy link

Describe the issue briefly here.

Environment Versions
  1. OS Type - Linux
  2. Python version: 3.7.2
  3. pip version: 19.0.3
  4. pip-tools version: 3.4.0
Steps to replicate
  1. I have compiled requirements.in with:
A>=8
B[tool_1,tool_2]>=7

(tool_1 requires package A in any version)
and compiled file:

A==9.0.3
B[tool_1,tool_2]==7.7.7
...
  1. I've added tool_3 to package B that require package A>=10:
    requirements.in
A>=8
B[tool_1,tool_2, tool_3]>=8.0.1
  1. Then I've run pip-compile and the result was:
A==9.0.3
B[tool_1,tool_2,tool_3]==8.0.1
Expected result

Package A in version 10+ in compiled file.

Actual result

I need to remove A from the compiled file, compile again and compiled file contains valid version .

@atugushev
Copy link
Member

Hello @Behoston,

Thank you for the report! Any chance to get a report with real packages? It would help a lot.

@Behoston
Copy link
Author

No, package B is our private package. But maybe I can do sth similar on test pypi.

@atugushev atugushev added the needs more info Need more info to clarify issue label Mar 27, 2019
@atugushev atugushev added the bug Something is not working label Apr 21, 2019
@atugushev atugushev removed the bug Something is not working label Jul 2, 2019
@atugushev atugushev added needs reproduce Need to reproduce an issue and removed needs more info Need more info to clarify issue labels Oct 17, 2019
@AndydeCleyre
Copy link
Contributor

@Behoston

Can you check if the behavior changes with #1486?

I'm wondering about the relation of this to #1451 and #852.

@AndydeCleyre
Copy link
Contributor

@Behoston

As the suspected related issues and PR are closed and merged, and many releases have gone by, can you still reproduce the problem?

@atugushev
Copy link
Member

It's been some time so I will close this issue now, but please don't hesitate to reach out if you have any other issues. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduce Need to reproduce an issue
Projects
None yet
Development

No branches or pull requests

3 participants