Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code owners file in repositories #486

Open
aleksihakli opened this issue Oct 16, 2019 · 3 comments
Open

Code owners file in repositories #486

aleksihakli opened this issue Oct 16, 2019 · 3 comments

Comments

@aleksihakli
Copy link
Member

Would Jazzband as a whole benefit from having .github/CODEOWNERS files defined for projects and should they be in the default checklists?

Refer to the discussion at:

@jezdez
Copy link
Member

jezdez commented Oct 17, 2019

Following my reply to @atugushev's discussion this will first require that all project get an own team. See the other TODO items I've posted there.

I'm against adding more teams for individual roles like per-project-reviewers as it increases the barriers of entry again and that conflicts with the core Jazzband concept. Every Jazzband member should be able and be encouraged to do reviews of all projects and we should not implement features that creates factions.

As such it makes sense to automatically add the per-project teams in the CODEOWNERS file since that's something we can easily explains to members as a reason to join a project team: ~"Join the project team to automatically receive code review requests by default.".

@atugushev
Copy link
Member

atugushev commented Nov 21, 2019

GitHub recently has deployed team settings for code review. That looks interesting:

image

More details here.

@blaisep
Copy link

blaisep commented May 28, 2024

Seems like something to consider for jazzband/help#366
Maybe as a project config checklist item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants