-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Java 17 LTE #27
Comments
Now I use https://gist.github.com/maxandersen/f077f1d356c42eeb395a8811d6152f3a to build Hello.java Docker image with Java 17. it's some slow to download JDK 17 by JBang. If you don't setup cache, and JBang will download JDK 17 every time when building image. |
+1 on finding way to build multiple versions per java and publish. |
Hi! We require JDK 21. As a workaround, we have checked out the repo and made this change to the Dockerfile and pushed the image to our own image registry: FROM eclipse-temurin:21-jdk-alpine As proposed earlier we also have chosen a suffix indicating the JRE flavor and release: Maybe something like this could be achieved with a GHA matrix based build, and keeping JDK 11 the default for backwards compatibility when no Java release suffix is present. |
I have start at jbangdev/jbang#1654 but haven't had time to finish it. Ps. In github actions I recommend using setup-jbang rather than the container image these days. It allows setting up specific java version with caching using setup-java. |
Just adding the link for easy reference: https://github.com/marketplace/actions/setup-jbang |
We should probably have a version of the action that supports Java 17 now that it's the latest long term support release.
This probably means coming up with a new tagging scheme, something like
jbangver-javaver
, eg0.83.0-11
,0.83.1-17
and a tag0.83.1
that refers to one of those, for now it should probably remain 11.The text was updated successfully, but these errors were encountered: