Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 17 LTE #27

Open
quintesse opened this issue Nov 25, 2021 · 5 comments
Open

Support Java 17 LTE #27

quintesse opened this issue Nov 25, 2021 · 5 comments

Comments

@quintesse
Copy link

quintesse commented Nov 25, 2021

We should probably have a version of the action that supports Java 17 now that it's the latest long term support release.

This probably means coming up with a new tagging scheme, something like jbangver-javaver, eg 0.83.0-11, 0.83.1-17 and a tag 0.83.1 that refers to one of those, for now it should probably remain 11.

@linux-china
Copy link

linux-china commented Apr 29, 2022

Now I use https://gist.github.com/maxandersen/f077f1d356c42eeb395a8811d6152f3a to build Hello.java Docker image with Java 17. it's some slow to download JDK 17 by JBang. If you don't setup cache, and JBang will download JDK 17 every time when building image.

image

@maxandersen
Copy link
Collaborator

+1 on finding way to build multiple versions per java and publish.

@mbechto
Copy link

mbechto commented Dec 5, 2023

Hi! We require JDK 21. As a workaround, we have checked out the repo and made this change to the Dockerfile and pushed the image to our own image registry:

FROM eclipse-temurin:21-jdk-alpine

As proposed earlier we also have chosen a suffix indicating the JRE flavor and release: jbang-action:v0.113.0-temurin21

Maybe something like this could be achieved with a GHA matrix based build, and keeping JDK 11 the default for backwards compatibility when no Java release suffix is present.

@maxandersen
Copy link
Collaborator

I have start at jbangdev/jbang#1654 but haven't had time to finish it.

Ps. In github actions I recommend using setup-jbang rather than the container image these days. It allows setting up specific java version with caching using setup-java.

@quintesse
Copy link
Author

Just adding the link for easy reference: https://github.com/marketplace/actions/setup-jbang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants