-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBang does not trust http sources #1696
Labels
bug
Something isn't working
Comments
Hi @DyspC I would like to work on this issue. |
Hello, no problem! |
yeah; seems like a simple fix of allowing http too...not sure why we even try add https:// if it does not start with https to start with. @ritikverma2000 or @DyspC if either of you are up for it feel free to open a PR! |
Fixed by #1698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Running
jbang http://my.server/static/script.jsh
always says the url is untrustedSelecting 2 to add the domain to trusted sources adds 'http://my.server/static/' to the trusted array (or says it's already present)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The user should not be asked again and again to add an already trusted source
JBang version
Additional context
I suppose this is because the trust evaluation prefixes it with "https://" and messes the URI parser
The text was updated successfully, but these errors were encountered: