Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open netlink socket with CLOEXEC #71

Closed
mbakhoff opened this issue Feb 8, 2020 · 3 comments
Closed

open netlink socket with CLOEXEC #71

mbakhoff opened this issue Feb 8, 2020 · 3 comments
Assignees
@jbaublitz
Labels
enhancement
Milestone
0.5.0

Comments

@mbakhoff
Copy link

mbakhoff commented Feb 8, 2020

The netlink socket is opened without the CLOEXEC flag. Rust standard library sets CLOEXEC for all the stuff it opens. Maybe it would make sense to do it in neli as well to avoid accidental leaks when creating child processes?

Should be easy to change in src/socket.rs NlSocket::new but it does have some backward compatibility concerns..

See also: rust-lang/rust#12148
@jbaublitz
Copy link
Owner

This seems very reasonable for v0.5.0. Just a note that I'm catching up after a long vacation so it may take a bit.

@jbaublitz jbaublitz added this to the 0.5.0 milestone Feb 8, 2020
@jbaublitz jbaublitz self-assigned this Feb 8, 2020
@jbaublitz jbaublitz mentioned this issue Apr 11, 2020
Merged
@jbaublitz
Copy link
Owner

See the linked PR. Once CI passes, I'll merge and this can get closed out. Thanks for letting me know about this and for your patience!

@mbakhoff
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbaublitz jbaublitz

Labels
enhancement
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@mbakhoff @jbaublitz