Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with _types #180

Closed
jbesomi opened this issue Sep 8, 2020 · 3 comments
Closed

Issues with _types #180

jbesomi opened this issue Sep 8, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jbesomi
Copy link
Owner

jbesomi commented Sep 8, 2020

  • Fix type checks to not fail if first value in series is NaN/missing, see Fix type checks to not fail if first value in series is NaN/missing. #174
  • We don't need anymore to check for RepresentationSeries
  • Then we might not need to check for the number of levels .. or s.index.nlevels != 1? Or if we do we should have a separate warning message "number of level is too high ..."
  • At line 163 of _types is written: "Check if a given Pandas Series has the properties of a RepresentationSeries.". Shouldn't we check for VectorSeries instead?
  • Some new representation functions might accept as input both a DataFrame and a VectorSeries. Does InputSeries deal with that? Do we need a more general approach?
@henrifroese
Copy link
Collaborator

henrifroese commented Sep 12, 2020

Checklist for the items:

@henrifroese
Copy link
Collaborator

Will leave this open until #157 is merged as we might encounter some more issues etc. 🤷 🤷‍♂️ 🤷‍♀️

@henrifroese
Copy link
Collaborator

Can be closed as #157 is merged, see comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants