Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isFloat() returns true for some GUIDs #47

Open
FarzadT opened this issue Aug 28, 2014 · 1 comment
Open

isFloat() returns true for some GUIDs #47

FarzadT opened this issue Aug 28, 2014 · 1 comment

Comments

@FarzadT
Copy link
Contributor

FarzadT commented Aug 28, 2014

In argument.js, isFloat() returns true for the following string "865fe326-2d1c-44a6-8719-d3c108fd649f"

@FarzadT
Copy link
Contributor Author

FarzadT commented Aug 28, 2014

I think the solution would be to check for

    // Handle ids that are not numbers but pass parseFloat test
    // (ie. Titan edge ids)
    if (_.isString(argument) && this.isFloat()) {
      return "'" + argument + "'";
    }

before

    if (this.isFloat()) {
      return this.value;
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant