Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMBDirEntryInformation.last_write_time is of type date, expected a datetime #279

Closed
christianknoepfle opened this issue Jun 5, 2024 · 3 comments

Comments

@christianknoepfle
Copy link
Contributor

Hi,

I was wondering why the SMBDirEntryInformation.last_write_time is defined as date and not datetime. All other *_time fields are defined as datetime. I just came across the issue, because intellij highlighted that as a warning in my code where I use a lot of typing.

When running some tests the field value is a datetime, so I would assume that this is a typo. Right or Wrong?

I am using the latest smbclient 1.13.0

Thanks and best regards

Christian

@adiroiban
Copy link
Contributor

Thanks for the report.

I see that hte change was introduced as part of this PR and it was reviewed and approved #251

I guess that datetime is the correct type.

If you have time, please consider creating a PR to fix this.

Thanks again!

@jborean93
Copy link
Owner

Thanks for the bug report and even more thanks for the PR that fixes this!

@jborean93
Copy link
Owner

Fixed by #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants