Some improvements to method validation #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rest Assured allows to test the body content even if the response is in error.
It seems better to be consistent with what is done in JaxrsScanningProcessor.
It is required by Jackson when serializing the violation report into a JSON entity.
cescoffier
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It started as a big change but in the end, I ended up with a far more conservative approach as we do not want to expose the internal services' constraint violations in the JSON output.
So it's all about small improvements and doc changes.
Here is the companion PR for the quickstart changes: quarkusio/quarkus-quickstarts#11 .