Fixes #520 accept debugger by default in dev mode #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Jan 16, 2019
| * | ||
| * false: The JVM is not started in debug mode true: The JVM is started in debug mode and suspends until a debugger is | ||
| * attached to 5005 client: The JVM is started in client mode, and attempts to connect to localhost:5005 {port}: The JVM is | ||
| * started in debug mode and suspends until a debugger is attached to {port} |
There was a problem hiding this comment.
Maybe it would be better with a proper list? It's not very readable right now.
gsmet
reviewed
Jan 16, 2019
| //to the runner jar | ||
| // we also want to add the maven plugin jar to the class path | ||
| // this allows us to just directly use classes, without messing around copying them | ||
| // to the runner jar |
There was a problem hiding this comment.
This PR is a good example of why we need a formatter.
There was a problem hiding this comment.
I just realised I had accidentally left the eclipse formatter enabled after my experiments
gsmet
reviewed
Jan 16, 2019
|
@stuartwdouglas nice table ;-) |
maxandersen
pushed a commit
to maxandersen/quarkus
that referenced
this pull request
Nov 5, 2022
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.