Fixes #656, JAX-RS injection factory is racey #657
Conversation
| feature.produce(new FeatureBuildItem(FeatureBuildItem.JAX_RS)); | ||
| List<Function<Object, Object>> unwrappers = new ArrayList<>(); | ||
| for (ProxyUnwrapperBuildItem i : proxyUnwrappers) { | ||
| unwrappers.add(i.getUnwrapper()); | ||
| } | ||
| template.setupIntegration(beanContainerBuildItem.getValue(), unwrappers); | ||
|
|
||
| return new ServletInitParamBuildItem("resteasy.injector.factory", ShamrockInjectorFactory.class.getName()); |
There was a problem hiding this comment.
There is a small change of behavior here as you now create this build item even if we don't find any application or resource.
I don't think it's an issue per se though but it resonates with a thought I had recently: currently if we want to bail out from a whole augmentation phase, we cannot do that easily (I have the same issue with Hibernate ORM, Validator, Search as if I don't have any entity/constraint/indexed entity I could bail out from the entire augmentation phase: it would be nice to have a nice way to bail out completely).
There was a problem hiding this comment.
Good point. The main reason why I needed to produce this here it to make sure that the static is set up (the way the RESTeasy SPI is there is not really anything I can do except use a static).
I might just move it all into the one method
…t least try run located java. (quarkusio#657) Co-authored-by: Max Rydahl Andersen <max@xam.dk>
No description provided.