Fix Hibernate cache random failures #694

[galderz]

• Caffeine offers no strict guarantees on which entity is evicted.
  Once the max is reached, there's no strict guarantees on which
  entity will be evicted, so we can't really to try to deterministically
  choose an entity to query after it's been evicted.
• Caffeine is not strict in its max size, it can run over for a little.
• Fix incorrect conversion from seconds to nanoseconds.

[galderz]

I'll wait until CI but I don't think this is fully fixed. Native image testing locally just threw:

Expected: is "OK"
  Actual: Oops, shit happened, No boot for you! java.lang.RuntimeException: [org.jboss.shamrock.example.infinispancachejpa.Person] expected Counts{puts=4, hits=0, misses=4, numElements=4} second level cache count, instead got: Counts{puts=0, hits=0, misses=4, numElements=0}
	java.lang.RuntimeException: [org.jboss.shamrock.example.infinispancachejpa.Person] expected Counts{puts=4, hits=0, misses=4, numElements=4} second level cache count, instead got: Counts{puts=0, hits=0, misses=4, numElements=0}
	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.assertCountEquals(InfinispanCacheJPAFunctionalityTestEndpoint.java:735)
	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.assertRegionStats(InfinispanCacheJPAFunctionalityTestEndpoint.java:730)
	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.verifyFindByIdPersons(InfinispanCacheJPAFunctionalityTestEndpoint.java:463)
	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.testReadOnly(InfinispanCacheJPAFunctionalityTestEndpoint.java:439)
	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.doStuffWithHibernate(InfinispanCacheJPAFunctionalityTestEndpoint.java:61)
	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.doGet(InfinispanCacheJPAFunctionalityTestEndpoint.java:47)

[galderz]

I'll wait until CI finishes and then close the PR, I've found another issue :)

[galderz]

Added a new commit that should fix any pending failures. Essentially, different parts of the Hibernate cache logic work with different units. These units are mandated by Hibernate cache SPI and Caffeine respectively and crucially they're in different units. Hibernate cache SPI defines next region timestamp in milliseconds while Caffeine works with nanoseconds.

[Sanne]

Looks nice, and worked locally. Waiting for CI to finish.

[dmlloyd]

Maybe we want to get rid of the "shit happened" bit at some point :)

[galderz]

Maybe we want to get rid of the "shit happened" bit at some point :)

Copy pasted that from somewhere else... 🙈