Netty extension #720
Netty extension #720
Conversation
| @@ -121,6 +121,7 @@ | |||
| <assertj.version>3.11.1</assertj.version> | |||
| <infinispan.version>10.0.0.Alpha3</infinispan.version> | |||
| <caffeine.version>2.6.2</caffeine.version> | |||
| <netty.version>4.1.30.Final</netty.version> | |||
There was a problem hiding this comment.
Worth adding that this version MUST match the version used by Vert.x, or not fun things are going to happen.
There was a problem hiding this comment.
@wburns ^ you're now in charge to coordinate any Netty upgrade in Infinispan with @cescoffier ;)
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package org.jboss.shamrock.vertx.runtime.graal; | |||
| package org.jboss.shamrock.netty.runtime.graalsubstitutions; | |||
There was a problem hiding this comment.
Is it worth changing graal to graalsubstitutions? Asking that because we use a graal package in other extensions and at some point it would be nice to be consistent and have clear conventions.
There was a problem hiding this comment.
I didn't change this, but ok I'll follow up with a consistency PR.
There was a problem hiding this comment.
Oh? Maybe the diff was misleading then.
There was a problem hiding this comment.
right. See the PR description ;)
The Github UI makes it look like I have modified
NettySubstitutions.java, but this isn't the case:we ended up having two copies, one better maintained than the other. I took the better one and this PR gets rid of the duplication.