Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Spring guide based on the existing quickstart #789

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 7, 2019

No description provided.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, added some comments inline.

docs/src/main/asciidoc/spring-di-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/spring-di-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/spring-di-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/spring-di-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/spring-di-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/spring-di-guide.adoc Outdated Show resolved Hide resolved
cli/common/src/main/filtered/extensions.json Outdated Show resolved Hide resolved
@gsmet gsmet added this to the 0.9.0 milestone Feb 8, 2019
@gsmet
Copy link
Member

gsmet commented Feb 8, 2019

@geoand I rebased and pushed an additional commit with some additional editorialization. Could you take a look?

Thanks!

@geoand
Copy link
Contributor Author

geoand commented Feb 8, 2019

Looks good, thanks @gsmet!

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it, then! Thanks.

@gsmet gsmet merged commit b0f56f3 into quarkusio:master Feb 8, 2019
@geoand
Copy link
Contributor Author

geoand commented Feb 8, 2019

Let's merge it, then! Thanks.

You are welcome!

@geoand geoand deleted the spring-guide branch February 8, 2019 10:45
maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants