Integrate MP-JWT extension #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested changes
Feb 11, 2019
.../jwt/deployment/src/main/java/org/jboss/shamrock/jwt/deployment/JWTAuthContextInfoGroup.java
Outdated
Show resolved
Hide resolved
.../jwt/deployment/src/main/java/org/jboss/shamrock/jwt/deployment/JWTAuthContextInfoGroup.java
Outdated
Show resolved
Hide resolved
.../jwt/deployment/src/main/java/org/jboss/shamrock/jwt/deployment/JWTAuthContextInfoGroup.java
Outdated
Show resolved
Hide resolved
extensions/jwt/deployment/src/main/java/org/jboss/shamrock/jwt/deployment/JwtProcessor.java
Outdated
Show resolved
Hide resolved
...s/jwt/runtime/src/main/java/org/jboss/shamrock/jwt/runtime/auth/JWTAuthMechanismFactory.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/org/jboss/shamrock/jwt/runtime/auth/MpJwtPrincipalCleanupHandler.java
Outdated
Show resolved
Hide resolved
...me/src/main/java/org/jboss/shamrock/jwt/runtime/auth/JWTAuthMethodExtensionSubstitution.java
Outdated
Show resolved
Hide resolved
.../security/deployment/src/main/java/org/jboss/shamrock/security/IdentityManagerBuildItem.java
Outdated
Show resolved
Hide resolved
...undertow/deployment/src/main/java/org/jboss/shamrock/undertow/ServletExtensionBuildItem.java
Outdated
Show resolved
Hide resolved
|
This needs to be rebased |
in a module external to the security extension.
|
This failure is not related, it was caused by merging two related PR's that both passed but broke the build when combined together. |
…CDI RequestScoped. Add support for the primitive types injection
|
The requested changes should all be in at this point as of the 0558042 rev. |
There was a problem hiding this comment.
Looks good to me. @starksm64 do you think there is value in keeping all 26 commits or do you want me to squash it into one?
|
They can be squashed. |
stuartwdouglas
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request add support for the MP-JWT 1.1 specification feature