Skip to content

Commit c81af6a

Browse files
committedJun 13, 2019
Enable Layout/EmptyLinesAroundAccessModifier cop
We sometimes say "✂️ newline after `private`" in a code review (e.g. rails#18546 (comment), rails#34832 (comment)). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (rubocop/rubocop#7059). That cop and enforced style will reduce the our code review cost.
1 parent 0ad238f commit c81af6a

File tree

434 files changed

+8
-514
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

434 files changed

+8
-514
lines changed
 

‎.rubocop.yml

+4
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ Layout/EndAlignment:
6161
Layout/EmptyLineAfterMagicComment:
6262
Enabled: true
6363

64+
Layout/EmptyLinesAroundAccessModifier:
65+
Enabled: true
66+
EnforcedStyle: only_before
67+
6468
Layout/EmptyLinesAroundBlockBody:
6569
Enabled: true
6670

‎actioncable/lib/action_cable/server/worker.rb

-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ def invoke(receiver, method, *args, connection:, &block)
6666
end
6767

6868
private
69-
7069
def logger
7170
ActionCable.server.logger
7271
end

0 commit comments

Comments
 (0)