Skip to content

Commit cb09616

Browse files
committed
Avoid exposing ActiveSupport::Testing::NoSkip
It's only meant for Rails internal use.
1 parent e33dbe1 commit cb09616

File tree

2 files changed

+9
-16
lines changed

2 files changed

+9
-16
lines changed

activesupport/lib/active_support/testing/no_skip.rb

-14
This file was deleted.

tools/test_common.rb

+9-2
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@
88
end
99

1010
if ENV["CI"]
11-
require File.join(__dir__, "../activesupport/lib/active_support/testing/no_skip")
12-
ActiveSupport::TestCase.include(ActiveSupport::Testing::NoSkip)
11+
module DisableSkipping # :nodoc:
12+
private
13+
def skip(message = nil, *)
14+
flunk "Skipping tests is not allowed in this environment (#{message})\n" \
15+
"Tests should only be skipped when the environment is missing a required dependency.\n" \
16+
"This should never happen on CI."
17+
end
18+
end
19+
ActiveSupport::TestCase.include(DisableSkipping)
1320
end

0 commit comments

Comments
 (0)