Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too complex to use with tomcat #318

Closed
TimYi opened this issue Jun 17, 2016 · 1 comment
Closed

Too complex to use with tomcat #318

TimYi opened this issue Jun 17, 2016 · 1 comment

Comments

@TimYi
Copy link

TimYi commented Jun 17, 2016

I tried pushy in normal java project, it works well.
But when I deploy it to tomcat, tcnative conflicts with tomcat. And netty-boot is too complex to use.
Tomcat local library has a tomcat-jni.jar which use the same namespace with tcnative. Tomcat's classloader will also cause some problem.
So far, I have no idea about how to use pushy within tomcat container.

@jchambers
Copy link
Owner

And netty-boot is too complex to use.

I don't mean to nit-pick, but do you mean alpn-boot rather than netty-boot?

Regrettably, alpn-boot and netty-tcnative are our only options right now, and there isn't much we can do from the Pushy side of things to improve the situation. The Tomcat/netty-tcnative conflict is a known issue. I would like to point out that if you use Tomcat without native extensions, there will be no conflict with netty-tcnative, though I recognize that's not a great option, either.

While I certainly acknowledge your concerns, I think it makes sense to close this issue because:

  • Even though it may be complicated, alpn-boot will get the job done, so there is a viable way to use Pushy inside a Tomcat container.
  • There isn't really any meaningful way for us to improve the situation beyond waiting for an upstream fix.

If you feel there's more specific action we can take, please post a comment here and we'll revisit the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants