-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom properties don't allow non-string values #974
Comments
@Pro100proff I've looked into this a little more and I think I misunderstood your original report. To be more precisely state what I think is happening here, I understand that:
If I'm understanding you correctly, then this behavior is expected and is, in fact, documented: pushy/pushy/src/main/java/com/eatthepath/pushy/apns/util/ApnsPayloadBuilder.java Lines 690 to 716 in 77453f3
If you want to change how custom properties are serialized, you'll need to use a different That said, I think there's room to make the documentation clearer in this case and will open a pull request to do exactly that. |
Discussed in #973
Originally posted by Pro100proff July 21, 2022
I have encountered with problem when I wanted to add custom property as my own object. I expected json object like this:
In reality, I got:
I checked the implementation and realised that it used toString method for the serialization custom properties.
Is there work around to solve it?
…but the APNs docs say:
…so Pushy's payload builder should probably allow custom properties with non-string values.
The text was updated successfully, but these errors were encountered: