Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

Store Component Sets in the ECS #127

Open
zicklag opened this issue Jul 1, 2021 · 1 comment
Open

Store Component Sets in the ECS #127

zicklag opened this issue Jul 1, 2021 · 1 comment
Labels
breaking A breaking changes of the API performance A performance improvement

Comments

@zicklag
Copy link
Contributor

zicklag commented Jul 1, 2021

If I understand correctly from what I've seen in bevy_rapier2d, it looks like it actually stores all of the simulation data such as rigid body positions, etc. in the bevy ECS, by implementing the ComponentSet trait. With the way we have heron right now we are storing the physics world data in Bevy resources that use arena based storage.

I'm curious if that has any advantages performance or otherwise and if that would be a useful strategy in heron or not. I'm mostly just musing over the possibility, but do you have any ideas why we would want to or not want to do that?

@jcornaz
Copy link
Owner

jcornaz commented Jul 2, 2021

Yes, that's something I had in mind as soon as I heard it would be possible with the new version of rapier.

In theory it should be as beneficial for heron as it is for bevy_rapier.

@jcornaz jcornaz added the performance A performance improvement label Jul 2, 2021
@jcornaz jcornaz added the up-for-grabs Good for newcomers label Oct 28, 2021
@jcornaz jcornaz changed the title [Idea] Store Component Sets in the ECS Store Component Sets in the ECS Mar 14, 2022
@jcornaz jcornaz added performance A performance improvement breaking A breaking changes of the API and removed up-for-grabs Good for newcomers performance A performance improvement labels May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking A breaking changes of the API performance A performance improvement
Projects
None yet
Development

No branches or pull requests

2 participants