Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online help: Rework of the help menu structure / hierarchie #206

Closed
ejfschmittel opened this issue Jun 3, 2020 · 3 comments
Closed

Online help: Rework of the help menu structure / hierarchie #206

ejfschmittel opened this issue Jun 3, 2020 · 3 comments
Milestone

Comments

@ejfschmittel
Copy link

ejfschmittel commented Jun 3, 2020

Issue Collection found going through JCryptool mostly relating to the help menu.

  • links on welcome page don't open the help navigation correctly
  • rework of the help menu structure / hierarchie
  • remove mention of error log view from view help & cheat sheet

Detailed information in the pdf JCryptool Issues.pdf

@grthor grthor added this to the Final 1.0.0 milestone Jun 3, 2020
@grthor
Copy link
Member

grthor commented Jun 4, 2020

I replaced the error log view with the frequency analysis plugin in de and en.
This change will be in the weekly build on saturday.

@grthor
Copy link
Member

grthor commented Jun 6, 2020

The help navigation will be correctly opened: 70ee319

The problems were "mistakes" in the links. Instead of a generic $nl$ which eclipse replaces automatically with the users language the language was hard coded with nl/de or nl/en. Replacing all nl/de and nl/en with $nl$ fixed the problem.

open

@grthor
Copy link
Member

grthor commented Jun 6, 2020

I noticed that nl/de and nl/en is used in several other places (some toc.xml and context.xml). I changed the occurences to $nl$ and tested the functionality of the edited parts. In all cases the functionality improved.

To give an example: The registration of the context help does not work 100% with nl/de. Only with $nl$ the help get registered to the correct position in the content tree.

wrong

I fixed all occurences of nl/de and nl/en:

@grthor grthor changed the title Issue list: update help navigation structure & welcome page link issue Online help: Rework of the help menu structure / hierarchie Jun 20, 2020
@simlei simlei closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants