refactor: Updating the MergeRequest API's pipeline function header

The function requires the mergerequestId but was exposing this parameter as optional. BREAKING CHANGE: MergeRequest Pipelines require the mergeRequestId
jdalrymple · May 25, 2019 · 46a541b · 46a541b
1 parent e4ba731
commit 46a541b
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/services/MergeRequests.ts b/src/services/MergeRequests.ts
@@ -182,11 +182,10 @@ class MergeRequests extends BaseService {
     return RequestHelper.get(this, `projects/${pId}/merge_requests/${mIId}/participants`, options);
   }
 
-  pipelines(projectId: ProjectId, { mergerequestId }: { mergerequestId?: string } = {}) {
-    const pId = encodeURIComponent(projectId);
-    const mergeRequest = mergerequestId ? `merge_requests/${encodeURIComponent(mergerequestId)}` : '';
+  pipelines(projectId: ProjectId, mergerequestIId: MergeRequestId, options?: Sudo) {
+    const [pId, mIId] = [projectId, mergerequestIId].map(encodeURIComponent);
 
-    return RequestHelper.get(this, `projects/${pId}/${mergeRequest}/pipelines`);
+    return RequestHelper.get(this, `projects/${pId}/merge_requests/${mIId}/pipelines`, options);
   }
 
   remove(projectId: ProjectId, mergerequestIId: MergeRequestId, options?: Sudo) {