fix: ResourceAwardEmojis API wasn't properly filtering based on awardId

jdalrymple · Oct 12, 2018 · 70f4315 · 70f4315
1 parent e9c8bb8
commit 70f4315
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/src/templates/ResourceAwardEmojis.ts b/src/templates/ResourceAwardEmojis.ts
@@ -1,16 +1,16 @@
 import URLJoin from 'url-join';
 import { BaseService, RequestHelper } from '../infrastructure';
 
-function url(projectId, resourceType, resourceId, noteId) {
+function url(projectId, resourceType, resourceId, awardId, noteId) {
   const [pId, rId] = [projectId, resourceId].map(encodeURIComponent);
   let output = `${pId}/${resourceType}/${rId}/`;
 
-  if (noteId) {
-    output += `notes/${encodeURIComponent(noteId)}/`;
-  }
+  if (noteId) output += `notes/${encodeURIComponent(noteId)}/`;
 
   output += 'award_emoji';
 
+  if (awardId) output += `/${encodeURIComponent(awardId)}/`;
+
   return output;
 }
 
@@ -24,22 +24,25 @@ class ResourceAwardsEmojis extends BaseService {
     this.resourceType = resourceType;
   }
 
-  all(projectId, resourceId, options, noteId) {
-    return RequestHelper.get(this, url(projectId, this.resourceType, resourceId, noteId), options);
+  all(projectId, resourceId, noteId) {
+    return RequestHelper.get(this, url(projectId, this.resourceType, resourceId, null, noteId));
   }
 
   award(projectId, resourceId, name, noteId) {
-    return RequestHelper.post(this, url(projectId, this.resourceType, resourceId, noteId), {
+    return RequestHelper.post(this, url(projectId, this.resourceType, resourceId, null, noteId), {
       name,
     });
   }
 
   remove(projectId, resourceId, awardId, noteId) {
-    return RequestHelper.delete(this, url(projectId, this.resourceType, resourceId, noteId));
+    return RequestHelper.delete(
+      this,
+      url(projectId, this.resourceType, resourceId, awardId, noteId),
+    );
   }
 
   show(projectId, resourceId, awardId, noteId) {
-    return RequestHelper.get(this, url(projectId, this.resourceType, resourceId, noteId));
+    return RequestHelper.get(this, url(projectId, this.resourceType, resourceId, awardId, noteId));
   }
 }