Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry configuration #3630

Open
2 tasks done
andys8 opened this issue Sep 26, 2024 · 0 comments
Open
2 tasks done

Retry configuration #3630

andys8 opened this issue Sep 26, 2024 · 0 comments
Labels
type:feature Changes add a new feature

Comments

@andys8
Copy link
Contributor

andys8 commented Sep 26, 2024

Description

Currently the http status codes leading to a retry are hardcoded with sensible defaults.

gitbeaker/packages/rest/src/Requester.ts

Line 80 in 141e50f

const retryCodes = [429, 502];

Proposal

While the default behavior is fine as is, it would nice to have more flexibility and allow configuring the status codes (optional).

Are you open to this suggestion? Do you have a preferred api in mind?

Checklist

  • I have checked that this is not a duplicate issue.
  • I have read the documentation.
@jdalrymple jdalrymple added the type:feature Changes add a new feature label Sep 26, 2024
@andys8 andys8 changed the title Retry configuraiton Retry configuration Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature Changes add a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalrymple @andys8