Revert "feature/character-list & feature/comic-list — Less verbose wr…

…iting for conditionals attributes" Because less verbose in that case means also less readable et I think less performant. This reverts commit d8bd718.
jeandat · Feb 27, 2016 · 0623a46 · 0623a46
1 parent d8bd718
commit 0623a46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/app/character/character-list.jade b/app/character/character-list.jade
@@ -9,10 +9,8 @@ ion-view.characters(view-title='Characters')
         .list
             .card.characters-card(ng-repeat="character in vm.characters track by character.id")
                 .item.item-image(ui-sref='app.character-detail({character:character})')
-                    div.characters-card__cover(
-                    ng-class='{"characters-card__cover--not-found": !character.thumbnailUrl}'
-                    ng-attr-img-cache='{{character.thumbnailUrl && true || undefined}}'
-                    ng-attr-ic-bg='{{character.thumbnailUrl || undefined}}')
+                    div.characters-card__cover(ng-if="character.thumbnailUrl" img-cache ic-bg="{{::character.thumbnailUrl}}")
+                    div.characters-card__cover.characters-card__cover--not-found(ng-if="!character.thumbnailUrl")
                 .item.item-icon-right.assertive.characters-card__footer
                     i.icon.ion-android-favorite-outline(ng-click='vm.keep()')
                     | {{::character.name}}

diff --git a/app/comic/comic-list.jade b/app/comic/comic-list.jade
@@ -9,10 +9,8 @@ ion-view.comics(view-title='Comics')
         .list
             .card.comics-card(ng-repeat="comic in vm.comics track by comic.id")
                 .item.item-image(ui-sref='app.comic-detail({comic:comic})')
-                    div.comics-card__cover(
-                    ng-class='{"comics-card__cover--not-found": !comic.thumbnailUrl}'
-                    ng-attr-img-cache='{{comic.thumbnailUrl && true || undefined}}'
-                    ng-attr-ic-bg='{{comic.thumbnailUrl || undefined}}')
+                    div.comics-card__cover(ng-if="comic.thumbnailUrl" img-cache ic-bg="{{::comic.thumbnailUrl}}")
+                    div.comics-card__cover.comics-card__cover--not-found(ng-if="!comic.thumbnailUrl")
                 .item.item-icon-right.assertive.comics-card__footer
                     i.icon.ion-android-favorite-outline(ng-click='vm.keep()')
                     | {{::comic.title}}