-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature/character-detail-comic-list — Comics list screen relative to …
…a character with infinite scroll. Pretty cool as space is reserved in the grid and there is no relayout.
- Loading branch information
Showing
13 changed files
with
70 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
.character-comics{ | ||
&__cover-container{ | ||
padding: $content-padding/2; | ||
} | ||
&__cover-wrapper{ | ||
position: relative; | ||
height: 0; | ||
overflow: hidden; | ||
// Clever technique to reserve space although we don't know the image size yet. | ||
// We can do that because we know the image aspect ratio and padding values | ||
// expressed in percentage are relative to the width. | ||
// http://andmag.se/2012/10/responsive-images-how-to-prevent-reflow/ | ||
padding-bottom: 450/300 * 100%; | ||
background-color: darken($base-background-color, 10%); | ||
} | ||
&__cover{ | ||
position: absolute; | ||
top: 0; | ||
left: 0; | ||
width:100%; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,11 @@ | ||
ion-view.character-comics(view-title='Comics') | ||
ion-content | ||
ion-content(delegate-handle='characterComicsHandle') | ||
.row.row-wrap | ||
.col-33.character-comics__cover-container(ng-repeat='comic in vm.comics track by $index') | ||
div.character-comics__cover-wrapper | ||
img.character-comics__cover(ng-if='::comic.thumbnailUrlInPortraitUncanny' img-cache ic-src='{{::comic.thumbnailUrlInPortraitUncanny}}' width='100%' height='auto' | ||
ui-sref='app.characterDetailComicDetail({comic:comic})') | ||
img.character-comics__cover(ng-if='::!comic.thumbnailUrlInPortraitUncanny' width='100%' height='auto' ng-src='img/image-not-available_portrait-uncanny.png' | ||
ui-sref='app.characterDetailComicDetail({comic:comic})') | ||
|
||
ion-infinite-scroll(on-infinite='vm.showMore()' distance='20%' immediate-check='false' ng-if='vm.hasMore') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.