Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new venv syntax #1303

Closed
jdx opened this issue Dec 31, 2023 · 2 comments
Closed

new venv syntax #1303

jdx opened this issue Dec 31, 2023 · 2 comments

Comments

@jdx
Copy link
Owner

jdx commented Dec 31, 2023

I think I want to move venv configuration for python/poetry into the [env] section rather than putting it on individual tools:

[env]
_.python.venv = "~/.venv/myvenv"
_.poetry.pyproject = "pyproject.toml"

this would make it still driven by the plugin (allowing other plugins to do similar things), but also make it possible to use with the system python resolving #1248.

More importantly though, this just feels like the more correct place to put it since it's configuring the "environment"—not the python installation. That said it will depend on that so a bit of care around making sure if there is a python version set it needs to be installed before setting the venv.

@rsyring
Copy link

rsyring commented Jan 11, 2024

I don't follow mise development close enough to know the genesis of the _ environment variables. That being said, I find it odd the settings would be there and not a part of the tool.

@camsteffen
Copy link

I think it's good that [env] has the single purpose of setting environment variables. It's analogous to a .env file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants