Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer reshape to view in computations #82

Open
odusseys opened this issue Sep 26, 2024 · 0 comments
Open

Prefer reshape to view in computations #82

odusseys opened this issue Sep 26, 2024 · 0 comments

Comments

@odusseys
Copy link

Thanks for your great work!
A slight issue in several functions of the library is that they use .view() to reshape inputs, which fails on non-contiguous tensors. For instance, the sinkhorn divergence scaling_parameters function fails if two noncontiguous tensors are passed to the loss function, which is unexpected. Using reshape instead would allow bypassing the need to explicitly make tensors contiguous before passing to SamplesLoss, while still creating views when possible and not sacrificing performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant