-
Notifications
You must be signed in to change notification settings - Fork 509
Should I care about this? #631
Comments
I received that message too. Do we need to do anything? |
I think the SDK needs to be updated in this repo and republished to NPM so we can update. |
|
@jeduan Can the SDK updated here? |
I’m not maintaining this anymore. Let me know if you’re up for this. |
This is probably not a big deal, as it even states that the update is simply a better login experience for 14% of users on iOS11. Nothing stated nor implied that any functionality will break. That's a shame, but thank you so much for the time you spent taking over the de facto official Facebook Cordova plugin @jeduan. I really hope we'll find someone to maintain it before actual breaking changes occur though. |
@jeduan I just provided a PR for this #634 Important: I'm a newbie in this field aka I'm no Cordova or neither Objective-C expert I have update the library, add a look to the declarations files differences (looks fine to me) and build it and finally tested "login" and "share" processes with my app (my productive app respectively in a real app where I would have been able to detect problems/incompatibilities) I would highly appreciate your expertise or the expertise of anyone else (@fredgalvao ?) to review the PR, I think it's a must here regarding my knowledges I tried my best, hope it gonna be ok for you guys |
@peterpeterparker Thanks for suggesting me (I'll take that as a compliment) but I can't review Objective-C or Swift code, as I have almost zero experience on both/any. I'm hoping you find someone to do it though, we need to keep this project updated somehow. |
@fredgalvao totally agree, hope we find someone to keep this project up and running p.s.: I'll keep in mind that your are then a Cordova/Android expert 😉 |
PR #634 is merged Update of the Facebook SDK as requested by Facebook will be published in v2.0.0 |
This has been now release to npm Plugin version v1.10.0 |
I have received this mail from Apple
Should I care, when using this cordova-plugin-facebook4?
The text was updated successfully, but these errors were encountered: