feat: add more precise end coordinates

[name-snrl]

Part

Library (crate)

Description

Hi, again. I'm using ltrs via null-ls as diagnostic tool. If the diagnostic starts on one line and ends on another, then the end of the diagnostic is out of range.

At the moment I've solved the problem with these lines in my null-ls fork, but I think it would be nice to have a more informative ltrs check output.

Screenshots

No response

Additional information

No response

[jeertmans]

Hello! Is it the « more context » field that is wrong? Or just null-ls that does not handle that?

do you have an example string for testing?

[name-snrl]

Is it the « more context » field that is wrong?

Not wrong, but not complete. It contains only line_number, but there should be an end_line.

example:

ltrs check -t 'Системы оркестрации:

- Kubernetes
- Docker swarm

Настройка CI процессов:

- GitLab CI
- Jenkins' -l auto --disabled-rules WHITESPACE_RULE

There is also an example with shellcheck for comparison:

#!/usr/bin/env bash

foo=abc
bar=xyz
declare -r str='
    foo: "'$foo'",
    blah: "blah",
    blah: "blah",
    blah: "blah",
    "bar:" "$bar",
}'

echo "$str"
echo $bar

x shellcheck -f json test.sh | jq
[
  {
    "code": 2016,
    "column": 16,
    "endColumn": 3,
    "endLine": 11,
    "file": "test.sh",
    "fix": null,
    "level": "info",
    "line": 6,
    "message": "Expressions don't expand in single quotes, use double quotes for that."
  }
]

[jeertmans]

Oh ok I get it :)

I guess I could easily add a new field to the moreContext structure. I am still wondering about the best name ^^’

[jeertmans]

Ok, so I will definitely implement this, but after looking at my code, I think MatchPositions and others related methods need some kind of rework :'-)