Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance existing repo with improved meta data #8

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Enhance existing repo with improved meta data #8

merged 3 commits into from
Apr 3, 2023

Conversation

jezumbro
Copy link
Contributor

Objective

Improve the interface to the repository by requiring the document_class and collection_name to be defined in the Meta of the new class

Notes

  • Adding document_class to Meta to improve the existing codebase.
  • Adding more types and moving the comments to be doc strings associated with the corresponding function
  • Refactored existing codebase
  • Ran black and isort on existing codebase

@jefersondaniel
Copy link
Owner

Can you include back and isort on development dependencies and scripts? So other maintainers keep the same pattern

https://github.com/jefersondaniel/pydantic-mongo/blob/main/phulpyfile.py

@jezumbro
Copy link
Contributor Author

jezumbro commented Apr 3, 2023

@jefersondaniel yes! Sorry I didn't mean to force isort and black on this project. I forget that my IDE is running those checks.

@jefersondaniel jefersondaniel merged commit 9c234d1 into jefersondaniel:main Apr 3, 2023
@jefersondaniel
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants