Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump versions. #2

wants to merge 1 commit into from

Conversation

bhansconnect
Copy link

Thought I might as well open a PR when I realized I wanted an updated git repo to point to.

closes #1

@powergee
Copy link

This patch solves potential future incompatibilities caused by an outdated package nom v5.1.2. Merging this change is needed to prevent this issue.

# The current build issues a warning that `nom` is outdated.
warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2`

@powergee
Copy link

powergee commented Apr 2, 2023

This also solves the problem that the build in ARM MacOS fails because no symbols are found in find_symbols. I think merging this PR is a good idea.

The current master branch gives me the following error:

error: failed to run custom build command for `setjmp v0.1.4 (/Users/hyeon/Repositories/setjmp-old)`

Caused by:
  process didn't exit successfully: `/Users/hyeon/Repositories/setjmp-old/target/debug/build/setjmp-21e2308b4ceefd94/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=wrapper.h
  cargo:rerun-if-changed=/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/setjmp.h
  cargo:rerun-if-changed=/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/sys/cdefs.h
  cargo:rerun-if-changed=/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/sys/_symbol_aliasing.h
  cargo:rerun-if-changed=/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/sys/_posix_availability.h
  cargo:rerun-if-changed=/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/Availability.h
  cargo:rerun-if-changed=/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/AvailabilityVersions.h
  cargo:rerun-if-changed=/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/AvailabilityInternal.h

  --- stderr
  thread 'main' panicked at 'assertion failed: vec.len() == 4', build.rs:77:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump versions
2 participants
@bhansconnect @powergee